Warn of wrong lockfile changes in PR #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7746 +/- ##
=======================================
Coverage 72.15% 72.16%
=======================================
Files 1267 1267
Lines 39706 39706
Branches 7370 7370
=======================================
+ Hits 28650 28653 +3
+ Misses 11056 11053 -3 ☔ View full report in Codecov by Sentry. |
fregante
commented
Feb 28, 2024
| ```sh | ||
| git checkout origin/main -- package-lock.json | ||
| npm install | ||
| ``` |
There was a problem hiding this comment.
I could actually run and push this directly, but let's see how many false positives we get first.
fregante
commented
Feb 28, 2024
| on: | ||
| pull_request: | ||
| paths: | ||
| - package-lock.json |
There was a problem hiding this comment.
Unrelated but this stops this other workflow from being activated at all on most non-dependabot PR
grahamlangford
approved these changes
Feb 28, 2024
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This keeps happening and it seems that it's wasting the team's time to fix it.
Demo
This should raise concerns:
This is a normal PR/fixed:
Checklist